Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 #324

Merged
merged 4 commits into from
Sep 22, 2023
Merged

1.20.2 #324

merged 4 commits into from
Sep 22, 2023

Conversation

AzureAaron
Copy link
Collaborator

  • Ports the mod to 1.20.2 and introduces some new patches relating to it
  • All of the stuff that changed has been tested and is fully working

Patches

As of 1.20.2 Mojang made changes to how loading player skin textures work (all texture payloads MUST have a signature) so I've added some patches to restore 1.20.1 functionality when on Hypixel:

  • Suppress log spam from 2 new sources relating to player skin textures having bad signatures
  • Fixes skin textures appearing as missing when Hypixel sends an invalid signature
    • Note: The Mixin catches all throwables which matches vanilla behaviour (Also, trying to implement it with an @Redirect or @WrapOperation caused Mixin itself to throw an NPE lmfao)

@AzureAaron AzureAaron added this to the update mc to 1.20.2 milestone Sep 22, 2023
@LifeIsAParadox LifeIsAParadox merged commit dbdb059 into master Sep 22, 2023
1 check passed
@LifeIsAParadox LifeIsAParadox deleted the 1.20.2 branch September 22, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants